-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CI based on Github Actions #21
base: master
Are you sure you want to change the base?
Conversation
It is a draft because there are still some errors in the build - https://github.com/martin-g/v3d_external/actions/runs/3281478805/. |
Builds on Linux x86_64 and aarch64 Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
c7f8826
to
68c2682
Compare
Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
e596a1a
to
0d0c1ed
Compare
The Azure one fails with: The following packages have unmet dependencies: libomp-dev : Depends: libomp5 (= 5.0.1-1) E: Unable to correct problems, you have held broken packages. Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
585423d
to
c07bfd5
Compare
This is needed because of: The repository will be downloaded using the GitHub REST API To create a local Git repository instead, add Git 2.18 or higher to the PATH Error: Input 'submodules' not supported when falling back to download using the GitHub REST API. To create a local Git repository instead, add Git 2.18 or higher to the PATH. Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
c07bfd5
to
444b9e3
Compare
Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
gcc-4.8 and g++-4.8 are available in stock Ubuntu 18.04 Docker images Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
07ebe10
to
1cef03a
Compare
Any feedback on the proposed changes ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Having CI on Linux ARM64 would be awesome!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I also needed to build on Linux ARM64 and this CI workflow helped me a lot to figure out the needed prerequisites!
Well done. @martin-g !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work, @martin-g !
This PR is really helpful to get the correct dependencies and build steps !
Builds on Linux x86_64 (native) and aarch64 (emulated via QEMU).